On Wed, Nov 13, 2013 at 04:36:06PM -0500, Jeff King wrote: > On Wed, Nov 13, 2013 at 01:05:58AM -0500, Jeff King wrote: > > > On v3.12, running "make -j16 test" on a git.git checkout produces random > > failures in the test suite, whereas it works fine on v3.11. > > [...] > > Reading the patch for 232d2d6, it seems plausible that it's a locking > > problem in the new code, but I don't see anything obviously wrong. I'd > > expect others can reproduce by running git's test suite, but if not, I'm > > happy to test patches. > > A word of warning to anyone who wants to reproduce this: I believe it > caused some data loss during my bisect. Git's test suite does a lot of: > > mkdir trash.XXXXX > ... do some tests in trash.XXXXX > rm -rf trash.XXXXX > > >From reading the patch, I'm guessing the bug is causing wrong dir > entries to be returned under load. Random bits of my home directory are > missing this morning after my testing; my theory is that when we are > unlucky enough to hit the race on the "rm", it can end up deleting > random things. Move initialization of dentry/vfsmount/mnt to just before the loop in prepend_path() and see if that fixes what you are seeing... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
