On 11/06/2013 09:12 AM, Chao Yu wrote:
> A NULL point should avoid to be used in destroy_segment_manager after allocating memory fail for f2fs_sm_info.
Though without this patch it still can work well, because if it failed
to allocate f2fs_sm_info, the sit_info, free_info... all were NULL, and
the destory path(e.g. destroy_dirty_segmap) can deal with them well.
IMO, this patch is still a good catch.
Regards,
Gu
>
> Signed-off-by: Chao Yu <chao2.yu@xxxxxxxxxxx>
> ---
> fs/f2fs/segment.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 3d4d5fc..ff363e6
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1744,6 +1744,8 @@ static void destroy_sit_info(struct f2fs_sb_info *sbi)
> void destroy_segment_manager(struct f2fs_sb_info *sbi)
> {
> struct f2fs_sm_info *sm_info = SM_I(sbi);
> + if (!sm_info)
> + return;
> destroy_dirty_segmap(sbi);
> destroy_curseg(sbi);
> destroy_free_segmap(sbi);
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
