Re: [PATCH 1/1] No need to do recovery if there is no available CP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013-11-03 (일), 23:08 +0800, Huajun Li:
> From: Huajun Li <huajun.li@xxxxxxxxx>
> 
> Normally we expect an empty partition after formatting by
> mkfs.f2fs. But in this case, when we format a dirty partition and mount
> it again. The former file will be recovered and available again! and
> kernel log shows a recovery procedure is evoked.
> This patch adds a new flag CP_EXIST_FLAG to indicate whether is a
> available CP, and do recovery only when this flag is set.

IMO, mkfs.f2fs should do the right thing to avoid this.
If storage does not support discard, mkfs.f2fs can simply address the
problem by writing one node block with zeros to prevent this.

And, if you introduce a new flag, mkfs.f2fs should do the same thing,
which means that mkfs.f2fs also needs to set the CP_EXIST_FLAG.
So then, it could not fix the bug.

How do you think? 

-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux