On Mon, Oct 28, 2013 at 8:44 PM, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> wrote:
> Hi,
>
> 2013-10-26 (토), 00:01 +0800, Huajun Li:
>> From: Huajun Li <huajun.li@xxxxxxxxx>
>>
>
> [snip]
>
>>
>> @@ -538,7 +553,7 @@ static int f2fs_write_data_page(struct page *page,
>> loff_t i_size = i_size_read(inode);
>> const pgoff_t end_index = ((unsigned long long) i_size)
>> >> PAGE_CACHE_SHIFT;
>> - unsigned offset;
>> + unsigned offset = 0;
>> bool need_balance_fs = false;
>> int err = 0;
>>
>> @@ -572,7 +587,14 @@ write:
>> err = do_write_data_page(page);
>> } else {
>> f2fs_lock_op(sbi);
>> - err = do_write_data_page(page);
>> + if (test_opt(sbi, INLINE_DATA) && (i_size <= MAX_INLINE_DATA)) {
>> + err = f2fs_write_inline_data(inode, page, offset);
>> + ClearPageDirty(page);
>
> Don't need to call ClearPageDirty(page).
>
Yes. I will remove it in next version, thanks.
>> + f2fs_unlock_op(sbi);
>> + goto out;
>> + } else {
>> + err = do_write_data_page(page);
>> + }
>> f2fs_unlock_op(sbi);
>> need_balance_fs = true;
>>
> --
> Jaegeuk Kim
> Samsung
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
