Re: [RFC][PATCH] nfsd regression since delayed fput()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 16, 2013 at 11:52 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> If anybody has better ideas, I'll gladly take those instead - this
> approach feels kludgy ;-/

It looks kludgy indeed, but I do like the concept of basically
rate-limiting delayed_fput_work.

At the same time, I worry that it will cause the same kinds of things
that we discussed for user processes: delayed fput can result in
visible semantic differences (eg silly-renames) if it is delayed past
other operations that care about elevated reference counts.

Now I hope that people don't nfs-(re)export nfs filesystems, so the
nfs silly-rename isn't necessarily an issue, but I could imagine other
similar things.

I dunno. I like the rate-limiting, I worry about unintended consequences.

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux