> /* > + * Return the parent directory on success. > + * > + * Return NULL to keep trying. > + * > + * Otherwise return an error. > + */ > +static int reconnect_one(struct vfsmount *mnt, struct dentry *pd, char *nbuf, int *noprogress) Please keep the lines under 80 characters. > + struct dentry *ppd; > + struct dentry *npd; Might as well use sensible names already when splitting it out instead of renaming them later down the series? Otherwise looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html