On Wed, Oct 02, 2013 at 09:04:48AM -0700, Christoph Hellwig wrote: > On Wed, Oct 02, 2013 at 11:43:20AM -0400, J. Bruce Fields wrote: > > > > Just for fun, I took a stab at an xfs-specific method. > > > > Pretty much untested and probably wrong as I know nothing about xfs, but > > it does seem like it allows some minor simplifications compared to the > > common helper. > > > > But as Christoph says other filesystems have the same problem so we > > probably want to fix the common helper anyway. > > You'll need this in at least ext4, btrfs, gfs2, ocfs2 and probably more. > So fixing this for real sounds like the best deal. Based on "git grep '\bget_name\b' fs/".... Actually gfs2 and btrfs already have their own get_name methods. They look like they probably handle 64-bit inodes fine. That leaves xfs, ext4, and ocfs2. Anyway I'm still in favor of fixing the helper. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
