Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > On Mon, Sep 30, 2013 at 1:01 PM, Waiman Long <waiman.long@xxxxxx> wrote: >> >> I think this patch is worth a trial if relevant hardware is more widely >> available. The TSX code certainly need to be moved to an architecture >> specific area and should be runtime enabled using a static key. We also need >> more TSX support infrastructure in place first. > > I think we can pick that up from Andi's patches, he should have that. > Although that did have very x86-specific naming (ie "xbegin"). And I > don't think he used "asm goto" to quite the same advantage as this - > and I think we do want to make sure that the overhead is minimal. FWIW my version #0 used asm goto directly, but I later switched to not using it to support more compilers and higher level abstractions (locks etc.) and use the same intrinsics as the user level guys are using. The two extra instructions from not using asm goto for xbegin don't matter all that much in the end. That's the old asm goto stuff I wrote originally (user level version): https://github.com/andikleen/tsx-tools/blob/master/include/rtm-goto.h There was also a kernel version of it that patched, right now this is done in the main TSX patchkit like this: https://git.kernel.org/cgit/linux/kernel/git/ak/linux-misc.git/commit/?h=hle312/rtm-base&id=9190346d57a9bc89e746aee774d07e54cd1e6e75 Essentially without RTM it just becomes and unconditional jump to the abort handler, xabort is a nop, and xtest always returns 0. -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
