Hi Gu > -----Original Message----- > From: Gu Zheng [mailto:guz.fnst@xxxxxxxxxxxxxx] > Sent: Monday, September 23, 2013 9:54 AM > To: Chao Yu > Cc: Kim Jaegeuk; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx; > linux-fsdevel@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; 谭姝 > Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneeded write checkpoint in > recover_fsync_data > > On 09/22/2013 03:51 PM, Chao Yu wrote: > > > Previously, recover_fsync_data still to write checkpoint when there is > > nothing to recover with normal umount image. > > It may reduce mount performance and flash memory lifetime, so let's > > remove it. > > > > Signed-off-by: Tan Shu <shu.tan@xxxxxxxxxxx> > > Signed-off-by: Yu Chao <chao2.yu@xxxxxxxxxxx> > > --- > > fs/f2fs/recovery.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index > > 51ef5ee..6988e1b 100644 > > --- a/fs/f2fs/recovery.c > > +++ b/fs/f2fs/recovery.c > > @@ -419,6 +419,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi) > > { > > struct list_head inode_list; > > int err; > > + int is_writecp = 0; > > "need_writecp" may be more suitable. Okay, it increase readability. I will change it. Thanks. > > Thanks, > Gu > > > > > fsync_entry_slab = f2fs_kmem_cache_create("f2fs_fsync_inode_entry", > > sizeof(struct fsync_inode_entry), NULL); @@ -436,6 +437,8 > @@ int > > recover_fsync_data(struct f2fs_sb_info *sbi) > > if (list_empty(&inode_list)) > > goto out; > > > > + is_writecp = 1; > > + > > /* step #2: recover data */ > > err = recover_data(sbi, &inode_list, CURSEG_WARM_NODE); > > BUG_ON(!list_empty(&inode_list)); > > @@ -443,7 +446,7 @@ out: > > destroy_fsync_dnodes(&inode_list); > > kmem_cache_destroy(fsync_entry_slab); > > sbi->por_doing = 0; > > - if (!err) > > + if (!err && is_writecp) > > write_checkpoint(sbi, false); > > return err; > > } > > --- > > > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
