On Fri, Sep 06, 2013 at 11:43:49AM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" <bfields@xxxxxxxxxx> > > I can't for the life of me see any reason why anyone would care whether > a dentry that is never hooked into the dentry cache would need > DCACHE_DISCONNECTED set. __d_shrink did before your PATCH 1/3. With that fixed your patch looks fine. > +/* > + * For filesystems that do not actually use the dentry cache at all, and > + * only ever deal in IS_ROOT() dentries: > + */ If you document the function it really should be a kerneldoc comment. Also the description, while technically correct, isn't all that useful. It need an explanation why the filesystem is fine with unhashed dentries, and the reason is that it never performs any lookups as it pins the dentries in memory. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
