On Wed, Aug 21, 2013 at 11:35 PM, Sage Weil <sage@xxxxxxxxxxx> wrote:
> On Wed, 21 Aug 2013, Sha Zhengju wrote:
>> Following we will begin to add memcg dirty page accounting around
>> __set_page_dirty_{buffers,nobuffers} in vfs layer, so we'd better use vfs interface to
>> avoid exporting those details to filesystems.
>>
>> Since vfs set_page_dirty() should be called under page lock, here we don't need elaborate
>> codes to handle racy anymore, and two WARN_ON() are added to detect such exceptions.
>> Thanks very much for Sage and Yan Zheng's coaching!
>>
>> I tested it in a two server's ceph environment that one is client and the other is
>> mds/osd/mon, and run the following fsx test from xfstests:
>>
>> ./fsx 1MB -N 50000 -p 10000 -l 1048576
>> ./fsx 10MB -N 50000 -p 10000 -l 10485760
>> ./fsx 100MB -N 50000 -p 10000 -l 104857600
>>
>> The fsx does lots of mmap-read/mmap-write/truncate operations and the tests completed
>> successfully without triggering any of WARN_ON.
>>
>> Signed-off-by: Sha Zhengju <handai.szj@xxxxxxxxxx>
>
> Reviewed-by: Sage Weil <sage@xxxxxxxxxxx>
>
> Would you like me to take this through the ceph tree?
>
Yes, of course. : )
BTW I lost my from: From: Sha Zhengju <handai.szj@xxxxxxxxxx>
Thank you!
--
Thanks,
Sha
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
