Can't really comment the patch, just a nit:
On 08/21, Andy Lutomirski wrote:
>
> +static bool may_flink(const struct path *path)
> +{
> + bool ret;
> + struct inode *inode = path->dentry->d_inode;
> +
> + /*
> + * This is racy: I_LINKABLE could be cleared between this check
> + * and the actual link operation.
OK,
> + spin_lock(&inode->i_lock);
> + ret = !!(inode->i_state & I_LINKABLE);
> + spin_unlock(&inode->i_lock);
so why do we need to take a lock ?
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
