On Tue, Aug 06, 2013 at 01:23:48PM -0700, Dave Hansen wrote:
> On 08/03/2013 07:17 PM, Kirill A. Shutemov wrote:
> > + if (PageTransTailCache(page)) {
> > + /* part of already handled huge page */
> > + if (!page->mapping)
> > + continue;
> > + /* the range starts in middle of huge page */
> > + partial_thp_start = true;
> > + start = index & ~HPAGE_CACHE_INDEX_MASK;
> > + continue;
> > + }
> > + /* the range ends on huge page */
> > + if (PageTransHugeCache(page) &&
> > + index == (end & ~HPAGE_CACHE_INDEX_MASK)) {
> > + partial_thp_end = true;
> > + end = index;
> > + break;
> > + }
>
> Still reading through the code, but that "index ==" line's indentation
> is screwed up. It makes it look like "index == " is a line of code
> instead of part of the if() condition.
I screwed it up myself. Otherwise, the line is too long. :-/
Probably, I should move partial page logic into separate function.
--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
