On Sun 28-07-13 18:35:12, Marco Stornelli wrote: > I'm doing a couple of test about O_TMPFILE on my fs. I can see that > when the file is closed the blocks allocated are not freed. It > happens because of i_mode, it isn't a regular file nor a directory > nor a link. I added S_IFREG in my implementation of tmpfile callback > when I have to call new_inode() and now it works, but am I missing > something here? No, I think you are right. We need to add S_IFREG to the mode we pass to ->tmpfile(). Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html