On Mon, 2013-07-22 at 14:57 -0700, Jeremy Allison wrote: > Here is a patch that Samba vendors have been using > to implement recvfile (copy directly from socket > to file). It can improve write performance on boxes > by a significant amount (10% or more). > > I'm not qualified to evaluate this code, Nor I really. This doesn't apply to current btw. Single comment: (just on a brief look) do_splice_from_socket with 64bit compilation appears to have a pretty large (~1500 byte) stack frame which doesn't seem very nice. maybe a malloc/free instead of stack for struct recvfile_ctl_blk rv_cb[MAX_PAGES_PER_RECVFILE]; struct kvec iov[MAX_PAGES_PER_RECVFILE]; -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
