On Mon, 8 Jul 2013 10:17:01 -0400 Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > On Fri, Jul 05, 2013 at 05:46:19PM -0400, Jeff Layton wrote: > > I think the bigger issue though is that looking at refcounts in order to > > determine when we have a conflicting open is just plain wrong. There are > > all sorts of reasons one might see a raised refcount that don't involve > > conflicting opens (Al's stat() example for instance). It seems like we > > ought to shoot for a solution that doesn't rely (solely) on inode and > > dentry refcounts. > > Note that NFSv4 write delegations will need to affect stat as well. > (Once you let a client perform writes locally, that client becomes the > authority on the attributes, so we have to call back to it on stat.) > > --b. Good point... I'm a little leery of changing how that check is done anyway. While it seems intuitive to (re)implement the i_readcount in a similar way to the i_writecount, I'd be concerned about callers relying on the existing behavior. So, I'm inclined to try and fix the race that Al has identified without changing the logic too much. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
