Re: [PATCH] hpfs: better test for errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 4, 2013 at 9:42 AM, Mikulas Patocka
<mikulas@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> hpfs: better test for errors
>
> The test if bitmap access is out of bound could errorneously pass if the
> device size is divisible by 16384 sectors and we are asking for one bitmap
[...]

Mikulas, *please* fix whatever scripts you (and apparently some other
people) use that causes the subject line to be repeated as the first
line of the body of the email too..

Whatever it is, it's annoying. I can edit the emails, but I know for a
fact that others don't, and sometimes I miss it too. Resulting in
commit messages that have that silly duplication. There are too many
examples of this in the kernel logs already, let's put an end to it.

The rule is:

 - the subject line is the summary line of the patch

 - if you want to explicitly add a summary line in the body (because
your subject line is something else - maybe you're replying in a
thread and don't want to break the thread subject), you can do it by
having

     Subject: summary-line-goes-here

the more common cases being that you want to specify authorship or
original date (which will obviously be set specifically and perhaps
not the way you like it in the mail headers).

But just repeating the summary line is *BROKEN*. What broken
scripts/scms do this crap?

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux