generic_file_llseek_size() handles whence values in a switch statement,
but it lacks cases for both SEEK_SET and invalid values. This causes it
to treat all invalid whence values as SEEK_SET, which is wrong.
We fix that by adding a case for SEEK_SET and a default case.
Signed-off-by: Richard Yao <ryao@xxxxxxxxxx>
---
fs/read_write.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/read_write.c b/fs/read_write.c
index 0343000..54b8808 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -81,6 +81,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
switch (whence) {
case SEEK_END:
offset += eof;
+ case SEEK_SET:
break;
case SEEK_CUR:
/*
@@ -118,6 +119,8 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,
return -ENXIO;
offset = eof;
break;
+ default:
+ return -EINVAL;
}
return lseek_execute(file, inode, offset, maxsize);
--
1.8.1.5
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
