On Fri, May 24, 2013 at 12:14:59PM -0400, Abhijith Das wrote: > > Hoping to revive the discussion for $SUBJECT since we ran out of time > when Boaz brought it up at LSF. > [ ... ] > For those who are interested, here are the patches (description in > previous email below): > https://bugzilla.redhat.com/show_bug.cgi?id=850426#c14 Some quick things that struck me as I glanced through the patches: - Please post the patch series, don't make us go digging through bugzilla. - Don't use variable size types in the ABI or you'll have to add compat_ wrappers to fix it all up on the stack when going between 32bit userspace and 64bit kernelspace. This is going to be especially nasty if this is a giant sequence of variable length blobs. +struct linux_xdirent { + unsigned long xd_ino; + char xd_type; + unsigned long xd_off; + struct xstat xd_stat; + unsigned long xd_reclen; + struct xdirent_blob xd_blob; +}; Notice how, in contrast, David was careful to use naturally aligned fixed-width types in his xstat patch. - z -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
