Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Steve French (2013-05-15 16:21:12)
> On Wed, May 15, 2013 at 3:16 PM, Chris Mason <chris.mason@xxxxxxxxxxxx> wrote:
> > truncate_inode_pages_range ends with invalidate.  It just locks the page
> > first and makes sure to wait for writeback if it was already in
> > progress.
> 
> Does
> 
>      truncate_inode_pages_range(&inode->i_data, destoff,
>                             PAGE_CACHE_ALIGN(destoff + len) - 1);
> 
> 
> I also am worried about what does:
> 
> 1) writing out data from start of previous page up to destoff (if
> destoff not page aligned, and first page dirty)
> 2) writing out data from dest+len through end of page (if destoff not
> page aligned, and last page dirty)
> 
> before tossing first through last page out

It does a check for a partial first page (sending down the partial
offset to invalidatepage), but the last page is fully truncated.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux