On 05/15/2013 12:45 PM, Jaegeuk Kim wrote: > Hi Jianpeng, > > Could you explain why this *should* be changed? > Thanks, > > 2013-05-14 (화), 20:06 +0800, majianpeng: >> Signed-off-by: Jianpeng Ma <majianpeng@xxxxxxxxx> >> --- >> fs/f2fs/debug.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c >> index 8d99437..0d6c6aa 100644 >> --- a/fs/f2fs/debug.c >> +++ b/fs/f2fs/debug.c >> @@ -175,12 +175,12 @@ get_cache: >> >> static int stat_show(struct seq_file *s, void *v) >> { >> - struct f2fs_stat_info *si, *next; >> + struct f2fs_stat_info *si; >> int i = 0; >> int j; >> >> mutex_lock(&f2fs_stat_mutex); >> - list_for_each_entry_safe(si, next, &f2fs_stat_list, stat_list) { >> + list_for_each_entry(si, &f2fs_stat_list, stat_list) { >> char devname[BDEVNAME_SIZE]; >> >> update_general_status(si->sbi); Hi, In general, if we want to do delete operation like list_delete(&si->stat_list) ,we can use list_for_each_entry_safe. Otherwise, we used list_for_each_entry. Thanks! Jianpeng Ma -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html