2013-05-15 (수), 12:47 +0900, Namjae Jeon: > > > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > > index 3df43b4..9641534 100644 > > --- a/fs/f2fs/node.c > > +++ b/fs/f2fs/node.c > > @@ -1492,6 +1492,8 @@ int recover_inode_page(struct f2fs_sb_info *sbi, > > struct page *page) > > new_ni = old_ni; > > new_ni.ino = ino; > > > Hi. Jaegeuk. > > I have a minor comment. > > + if (!inc_valid_node_count(sbi, NULL, 1)) > > + WARN_ON(1); Hi Namjae, Negative since inc_valid_node_count() is not for debugging. IMO, for readability, we need to make clear what the function call is used for. Thank you for the review. :) > How about change WARN_ON(!inc_valid_node_count(sbi, NULL, 1)); ? > > Reviewed-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx> > Thanks. > > set_node_addr(sbi, &new_ni, NEW_ADDR); > > inc_valid_inode_count(sbi); > > > > -- > > 1.8.1.3.566.gaa39828 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Jaegeuk Kim Samsung
Attachment:
signature.asc
Description: This is a digitally signed message part
