Hi Ryusuke, On Tue, 2013-05-14 at 03:18 +0900, Ryusuke Konishi wrote: [snip] > > > /** > > + * nilfs_palloc_count_max_entries - count max number of entries that can be > > + * described by @desc_blocks > > + * @inode: inode of metadata file using this allocator > > + * @desc_blocks: descriptor blocks count > > + */ > > +u64 nilfs_palloc_count_max_entries(struct inode *inode, > > + unsigned int desc_blocks) > > The logical upper limit of descriptor block count is 2 ^ 43 (in the > case of 64-bit architecture), so the desc_blocks argument should have > unsigned long type. > I think that in real world the int type will be enough for descriptor blocks count. Moreover, I use atomic_t type for storing knowledge about current known descriptor blocks count in nilfs_mdt_info structure. If you insist on using unsigned long type then atomic_t type is not good choice. But do you really think that we have to use the unsigned long type for descriptor blocks count? With the best regards, Vyacheslav Dubeyko. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
