On Thu, 2013-05-09 at 20:37 +0400, Vyacheslav Dubeyko wrote: > Hi, > > This patchset implements ACLs support in hfsplus driver and generalizes NFSv4 ACLs <-> POSIX ACLs mapping algorithms. > > v3->v4 > * Introduce interface of NFSv4 ACLs <-> POSIX ACLs mapping (J. Bruce Fields request). > * Introduce generalization of NFSv4 ACLs <-> POSIX ACLs mapping algorithms (J. Bruce Fields request). > * Rework ACLs support in HFS+ driver with the purpose of using generalized mapping algorithms. > * Change dprint() on hfs_dbg() calls. > * Enhance debug output in fs/hfsplus/acl.c. > > v2->v3 > * Fix errors in dprint_hexdump() macro. > * Correct format on %zd for size_t in dprint() calls. > > v1->v2 > * Add several dprint() messages. > * Change hardcoded function names on __func__ macro. > * Fix coding style errors. > > The include/linux/nfs4acl.h header file is created with the purpose of sharing declarations and structures that were moved from fs/nfsd/nfs4acl.c and fs/nfsd/acl.h. Moreover, this header file introduces declaration of operations (nfsv4_ace_operations, nfsv4_ace_flags_operations, nfsv4_acl_id_operations, nfsv4_acl_mapping_operations) that can be specialized in concrete file system driver in the case of necessity. Otherwise, it is possible to use generalized mapping code without operations specialization. And, finally, it is declared nfsv4_acl_info structure that includes operations, pointer on mapping NFSv4 ACL and pointer on special mapping environment of concrete file system. > > The essence of mapping algorithms (located in fs/nfsd/nfs4acl.c, previously) were generalized and moved in fs/nfs4acl.c with the purpose of sharing between file system drivers. A concrete file system driver can use mapping code by means of map_posix_acl_to_nfsv4_one(), map_nfsv4_acl_to_posix(), nfs4_acl_posix_to_nfsv4(), nfs4_acl_nfsv4_to_posix() methods. Also, it is possible to specialize internal mapping operations in the case of very special way of operations under raw structures for concrete file system driver case. > > Mac OS X supports NFSv4 ACLs. It keeps its in the form of specially named xattr (com.apple.system.Security). HFS+ driver uses generalized implementation of NFSv4 ACLs <-> POSIX ACLs mapping algorithms. But it should be specialized internal mapping operations for the proper conversion of raw NFSv4 ACLs representation on HFS+ volume into POSIX ACLs. Thereby, it were implemented in hfsplus driver all necessary specialized internal mapping operations. How does this make sense? There is no lossless mapping of NFSv4 acls into POSIX acls; the latter doesn't have any equivalent of the DENY aces so you cannot represent the full set of acls that can be set using MacOS on the same filesystem. Shouldn't you rather be looking at the richacl patch sets? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
