On Mon, May 06, 2013 at 07:28:19AM -0400, Chris Mason wrote: > Quoting Dave Chinner (2013-05-05 18:44:16) > > On Sun, May 05, 2013 at 10:38:12AM -0400, Chris Mason wrote: > > > > It's an rbtree per allocation group. The code is doing an exact > > extent match and there is potential for multiple buffers at the same > > offset (key) into the tree so we can't use a radix tree at all. See > > _xfs_buf_find() for the rbtree search code... > > The exact match part won't work with my current code. But a small > change will let you pick your own insertion point and allow the > duplicates. I'll have to break up deletion a little as well, but it is > already setup for this. > > After the merge window, I've got linuxcon japan. Once both are done > I'll pick this up again and see what I can do. No worries - I'm not in any hurry to replace this code right now. Reducing the number of unnecessary/repeated buffer lookups is probably a bigger win for XFS right now... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
