Resend due to mail client problem. Marco 2013/4/17 Marco Stornelli <marco.stornelli@xxxxxxxxx> > > Hi, > > > 2013/4/15 Jan Kara <jack@xxxxxxx> >> >> On Sat 13-04-13 12:35:54, Marco Stornelli wrote: >> > Added a new enum to decide if we want to sleep in uninterruptible or >> > killable state or we want simply to return immediately. >> I like the patch. You can add: >> Reviewed-by: Jan Kara <jack@xxxxxxx> >> >> Honza >> > I'm happy if we can include the patches. However I do an update about the on-going and additional work: the patches submitted can be applied as-is, however, I'm still working on extending the killable path in mnt_want_write/mnt_want_write_file and I'm seeing if it's possible to change even the page_mkwrite path. In the first case, as Al said, there are three clear "hot" points, do_last, kern_path_create and mq_open. However I modified the code carefully in these code paths and I did some basic tests and it works. I'm going to submit the patch next week for a review if I'm able to do more tests. About the page_mkwrite path and the return value VM_FAULT_RETRY: the return value of get_user_pages can be 0 in case of VM_FAULT_RETRY. The caller set the nonblocking flag and it can manage the situation. Blocking callers, instead, have a BUG_ON on the return value of 0. They want either an error code or the number of pages gotten. A little modification of __get_user_pages can do the work. However, page_mkwrite could return VM_FAULT_RETRY even if the flag FAULT_FLAG_ALLOW_RETRY is not set, I don't know if it's correct and this flag in each case, at the moment, it's not visibile in page_mkwrite. In addition, I need to understand if a skip can be useful, or in each case the process will go to sleep in uninterruptible state in a step forward. Any comments is welcome. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
