--- On Mon, 15/4/13, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Mon, 2013-04-15 at 04:46 +0100, > Hin-Tak Leung wrote: > > > By converting this dprint() to pr_debug(), it > would > > > print out on a multiple lines, one for each read. > > > > > > That's why it should use a mechanism like > dbg_cont. > > > > > > btw: there is no current pr_debug_cont mechanism. > > > > That's rubbish. > > Don't be silly. > > > dprint() are compiled in/out debug printing > statements, > > and are entirely suppressed in unmodified kernel > source > > Of course. > > > I am not saying what I have in private is correct > > Then your original post wasn't useful either. > > > What I am saying is that the code snipplet I posted is > functional: > > Lots of code is functional, I prefer functional > and correct though. > > cheers, Joe Hmm, you obvious has a different meaning of "functional" than I. How is converting a few hundred lines of "print nothing" to another few hundred lines of "print nothing" functional? What does it achieve? I have already voiced my (admittedly selfish) concern: changing a few hundred lines of "print nothing" to another few hundred lines of "print nothing" means some of us who have substantial work-in-progress patches needs to spend a fair amount of time on rebase, and manually resolving conflicts from rebase. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
