On Wed, Apr 10, 2013 at 11:58:27AM -0400, Steve Dickson wrote: > > > On 10/04/13 11:25, J. Bruce Fields wrote: > > On Tue, Apr 02, 2013 at 05:46:00PM -0400, Steve Dickson wrote: > >> From: Steve Dickson <steved@xxxxxxxxxx> > >> > >> This enable NFSv4.2 support for the server. To enable this > >> code do the following: > >> echo "+4.2" >/proc/fs/nfsd/versions > > > > The patches are ordered strangely: labeled nFS support depends on 4.2 > > support, so we should be adding 4.2 support first, then labeled NFS > > support on top of that. > Seriously that actually matter? So you want just commit the 4.2 and not > not the label NFS patches? Yes, please, let's get that fixed on both the client and server, even though, yes I expect we'll probably commit them all at once. > > Note a 4.1 client shouldn't see the server return the new attribute as > > supported unless it's using 4.2, and attempts to set it should error > > out unless it's using 4.2. > How is that handled with 4.0 vers 4.1? Just looking for a point to the code... I don't actually remember. Grepping around.... Looks like it's mainly the nfsd_suppattrs{0,1,2} functions in fs/nfsd/nfsd.h. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html