Re: [PATCH] fs: take i_mutex in __page_symlink()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 01, 2013 at 05:35:38PM +0100, Al Viro wrote:
> > This was discovered by the addition of a new ext4 debugging assertion
> > which checked to make sure i_mutex was locked before calling
> > ext4_truncate().
> 
> 	I doubt that it's worth doing (inode has just been created and
> nobody else should have references to it - it's not fully set up, after
> all)...

Well, my other option is to drop the assert in ext4_truncate(), which
I thought was a good thing from a perspective of defensive
programming, or to grab the mutex in ext4_symlink() which is what
calles __page_symlink().

Would you prefer that we take the mutex in ext4_symlink() instead?

      	  	      	      	  	- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux