(2013/03/29 18:13), Glauber Costa wrote: > The sysctl knob sysctl_vfs_cache_pressure is used to determine which > percentage of the shrinkable objects in our cache we should actively try > to shrink. > > It works great in situations in which we have many objects (at least > more than 100), because the aproximation errors will be negligible. But > if this is not the case, specially when total_objects < 100, we may end > up concluding that we have no objects at all (total / 100 = 0, if total > < 100). > > This is certainly not the biggest killer in the world, but may matter in > very low kernel memory situations. > > [ v2: fix it for all occurrences of sysctl_vfs_cache_pressure ] > > Signed-off-by: Glauber Costa <glommer@xxxxxxxxxxxxx> > Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > CC: Dave Chinner <david@xxxxxxxxxxxxx> > CC: "Theodore Ts'o" <tytso@xxxxxxx> > CC: Al Viro <viro@xxxxxxxxxxxxxxxxxx> I think reasonable. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
