2013-03-27 (수), 09:57 +0900, Namjae Jeon: > 2013/3/27, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>: > > 2013-03-26 (화), 09:48 +0900, Namjae Jeon: > >> 2013/3/25, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>: > >> > This patch removes data_version check flow during the fsync call. > >> > The original purpose for the use of data_version was to avoid writng > >> > inode > >> > pages redundantly by the fsync calls repeatedly. > >> Hi Jaegeuk. > >> > However, when user can modify file meta and then call fsync, we should > >> > not > >> > skip fsync procedure. > >> I have a question. > >> Which case does user can directly modify meta ? Recovery tool ? > > > > The meta means the inode information like atime, mtime, size, and so on, > > which can be modified by setattr() or something other vfs apis. > > Thanks, > I understood. Thanks for your explanation :) > One more,, > When inode state is !(inode->i_state & I_DIRTY)), We don't need to skip ? Even though fsync writes no data and the inode is clean, we should mark the inode to recover after power-off-recovery. Any data and its inode can be written to the disk clearly before fsync was called. Thanks, > > Thanks. > > > >> > >> Thanks. > >> > >> > So, let's remove this condition check and hope that user triggers in > >> > right > >> > manner. > >> > > >> > Signed-off-by: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" > >> in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > > Jaegeuk Kim > > Samsung > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Jaegeuk Kim Samsung
Attachment:
signature.asc
Description: This is a digitally signed message part
