On Wed, Mar 13, 2013 at 7:37 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: > On 2013-03-13 7:12 PM, Robin Holt wrote: >> On Wed, Mar 13, 2013 at 05:51:33PM +0100, Sedat Dilek wrote: >>> On Wed, Mar 13, 2013 at 5:21 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >>> > On Wed, Mar 13, 2013 at 5:10 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: >>> > >>> >> Anyway, with CONFIG_OVERLAYFS_FS=m I do not see any related messages >>> >> when the kernel-module is loaded. >>> >> So, is this intended? >>> >> SquashFS prints into the logs, so what is it doing differently? >>> > >>> > Some modules do, some don't. It's not compulsory and not very useful. >>> > >>> >>> What about... >>> >>> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c >>> index 482c26f..92b9ad5 100644 >>> --- a/fs/overlayfs/super.c >>> +++ b/fs/overlayfs/super.c >>> @@ -675,11 +675,13 @@ MODULE_ALIAS_FS("overlayfs"); >>> static int __init ovl_init(void) >>> { >>> return register_filesystem(&ovl_fs_type); >>> + printk(KERN_INFO "overlayfs: loaded\n"); >> >> How about pr_debug(). That makes things quite for most of us but gives >> you info when looking for things like boot problems. > How is having a printk/pr_debug useful here at all? The fact that other > filesystems do this as well is not a good reason... > Also, putting it *after* the return statement doesn't make much sense ;) > Hehe, I just checked my new kernel... that does not work (nothing in the logs). But I think it's good to see if the filesystem is registered/loaded. - Sedat - > - Felix > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html