On Mon, 4 Mar 2013 16:08:30 -0600 Steve French <smfrench@xxxxxxxxx> wrote: > Resending patch to a slightly broader list for last minute check if > anyone objects. Although setting this particular socket option > (TCP_NODELAY) may not be as useful when corking/uncorking explicitly, > I want to doublecheck before removing them because there has been some > utility to the server allowing override of various sockopt options. > Samba server has long supported at least the following set of settable > socket options (although I don't know if the defaults are frequently > overridden now, by setting sockopts in smb.conf as used to be common > for the server). > > SO_KEEPALIVE > SO_REUSEADDR > SO_BROADCAST > TCP_NODELAY > IPTOS_LOWDELAY > IPTOS_THROUGHPUT > SO_SNDBUF * > SO_RCVBUF * > SO_SNDLOWAT * > SO_RCVLOWAT * > > * takes an integer argument rather than a boolean on/off > > Any objections to removing the ability to set socket options > explicitly for the cifs network file system client? > A couple of points... The sockopt= option was never documented in the mount.cifs manpage and the only value it ever accepted was TCP_NODELAY. Now that we're explicitly corking the socket, TCP_NODELAY has no effect. I don't think there's any value in leaving in a "placeholder" socket= option. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
