On Mar 2, 2013, at 2:52 AM, Andrew Morton wrote: > On Fri, 1 Mar 2013 15:47:10 -0800 > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > >> On Tue, 19 Feb 2013 17:20:47 +0400 >> Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: >> >>> This patch adds implementation of the ACLs support for hfsplus driver. >> >> It adds a few compilation warnings (use %zd for size_t) and also adds a >> bunch of compilation errors which get fixed up in the next patch. This >> causes problems for people who are doing bisection searches. >> >> I'll drop the patches. Please fix all this up? > > err, > > fs/hfsplus/acl.c: In function 'hfsplus_get_acl': > fs/hfsplus/acl.c:1257: error: implicit declaration of function '__hfsplus_getxattr' > fs/hfsplus/acl.c: At top level: > fs/hfsplus/acl.c:1343: error: redefinition of 'hfsplus_init_acl' > fs/hfsplus/xattr.h:42: note: previous definition of 'hfsplus_init_acl' was here I can't reproduce errors with implicit declaration and redefinition. I think that it is possible in the case of troubles with patchset applying. Had you any troubles with it? I send the new version of patchset. I checked it applying and compilation. So, I hope that all will be fine. With the best regards, Vyacheslav Dubeyko. > fs/hfsplus/acl.c: In function 'hfsplus_xattr_get_acl': > fs/hfsplus/acl.c:1411: warning: format '%ld' expects type 'long int', but argument 5 has type 'size_t' > fs/hfsplus/acl.c: In function 'hfsplus_xattr_set_acl': > fs/hfsplus/acl.c:1440: warning: format '%ld' expects type 'long int', but argument 5 has type 'size_t' > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
