From: Jan Kara <jack@xxxxxxx> Subject: fs: fix hang with BSD accounting on frozen filesystem When BSD process accounting is enabled and logs information to a filesystem which gets frozen, system easily becomes unusable because each attempt to account process information blocks. Thus e.g. every task gets blocked in exit. It seems better to drop accounting information (which can already happen when filesystem is running out of space) instead of locking system up. So we open the accounting file with O_NONBLOCK. Signed-off-by: Jan Kara <jack@xxxxxxx> Reported-by: Nikola Ciprich <nikola.ciprich@xxxxxxxxxxx> Tested-by: Nikola Ciprich <nikola.ciprich@xxxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Joel Becker <jlbec@xxxxxxxxxxxx> Cc: Mark Fasheh <mfasheh@xxxxxxxx> Cc: Marco Stornelli <marco.stornelli@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/acct.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN kernel/acct.c~fs-fix-hang-with-bsd-accounting-on-frozen-filesystem kernel/acct.c --- a/kernel/acct.c~fs-fix-hang-with-bsd-accounting-on-frozen-filesystem +++ a/kernel/acct.c @@ -201,7 +201,8 @@ static int acct_on(struct filename *path struct bsd_acct_struct *acct = NULL; /* Difference from BSD - they don't do O_APPEND */ - file = file_open_name(pathname, O_WRONLY|O_APPEND|O_LARGEFILE, 0); + file = file_open_name(pathname, + O_WRONLY|O_APPEND|O_LARGEFILE|O_NONBLOCK, 0); if (IS_ERR(file)) return PTR_ERR(file); _ -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
