On Sun, Feb 17, 2013 at 05:11:01PM -0800, Eric W. Biederman wrote: > From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> > > In xfs_create and xfs_symlink compute the desired kprojid and pass it > down into xfs_ialloc. NACK. The first time you posted this code I NACKed it because: >> This sort of thing just makes me cringe. This is all internal >> project ID management that has nothing to do with namespaces. >> It's for project ID's that are inherited from the parent inode, >> and as such we do not care one bit what the namespace is. >> Internal passing of project IDs like this this should not be >> converted at all as it has nothing at all to do with the >> namespaces. Please drop this patch or replace it with a simple patch that passes the project ID as an xfs_dqid_t (i.e. a flat, 32 bit quota identifier) instead so you can kill the prid_t type. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
