2013/2/12, Dave Chinner <david@xxxxxxxxxxxxx>: > On Mon, Feb 11, 2013 at 05:25:58PM +0900, Namjae Jeon wrote: >> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx> >> >> This patch is a follow up on below patch: >> >> [PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type >> commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63 > .... >> diff --git a/fs/xfs/xfs_export.c b/fs/xfs/xfs_export.c >> index a836118..3391800 100644 >> --- a/fs/xfs/xfs_export.c >> +++ b/fs/xfs/xfs_export.c >> @@ -48,7 +48,7 @@ static int xfs_fileid_length(int fileid_type) >> case FILEID_INO32_GEN_PARENT | XFS_FILEID_TYPE_64FLAG: >> return 6; >> } >> - return 255; /* invalid */ >> + return FILEID_INVALID; /* invalid */ >> } > > I think you can drop the "/* invalid */" comment from there now as > it is redundant with this change. Okay, Thanks for review :-) > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
