Re: [RFC] fuse: consistently use readdirplus offsets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> On Tue, Feb 5, 2013 at 4:12 AM, Eric Wong <normalperson@xxxxxxxx> wrote:
> > Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> >> I think the problem is that directory offsets are not consistent
> >> between readdir and readdirplus.  The solution is that userspace
> >> should always use the same offsets.  This makes the readdirplus
> >> implementation more complex but that's really the only sane thing to
> >> do.
> >
> > I think something like the following is necessary in the kernel, too.
> > (Userspace patch coming)
> 
> Can you please explain what this patch is trying to do?  Because I
> think it's not doing what it wants ;)

I admit I'm not sure why your original email only said:

	userspace should always use the same offsets

instead of:

	kernel and userspace should always use the same offsets

This patch makes the kernel always use the same offsets, as does
v2 of my high-level userspace patch.

Anyways, I've tested this patch together with my v2 userspace patch and
got the results I expected with adaptive readdirplus.

Perhaps I have two bugs nullifying each other?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux