Hi Minchan, On 02/05/2013 03:45 PM, Minchan Kim wrote: >> So it may not a good idea that we all fall into calling the *non_movable* version of >> > GUP when CONFIG_MIGRATE_ISOLATE is on. What do you think? > Frankly speaking, I can't understand Mel's comment. > AFAIUC, he said GUP checks the page before get_page and if the page is movable zone, > then migrate it out of movable zone and get_page again. > That's exactly what I want. It doesn't introduce GUP_NM. Since an long time pin or not is an unpredictable behave except you know what the caller wants to do. We have to check every time we call GUP, and GUP may need another parameter to teach itself to make the right decision? We have already got *8* parameters :( thanks, linfeng -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html