On Tue, Jan 29, 2013 at 07:16:11PM -0500, Jeff Layton wrote: > I see no reason to wait until after the "set" operation returns to set > the s_type. We do call destroy_super() in some cases with that value > unset. That seems to be OK in almost all cases, but we had a fire-drill > recently with some RHEL-only patches that oopsed because the s_type was > unset when destroy_super() got called. > > Move the setting of the s_type into alloc_super() as a defensive coding > measure. NAK. If anything, I'm seriously tempted to zero ->s_type in deactivate_locked_super() just before we do put_filesystem_type() and that reference becomes garbage. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
