Hi,
On Tue, Jan 29, 2013 at 12:43 PM, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> wrote:
> Great job. Thank you for the work.
> BTW, as I see your patches in the repo, it would be better to modify the
> following patch.
> Except this, everything looks good to me at a glance.
>
> 0002-vfs-export-symbol-d_find_any_alias.patch
> - Let's avoid modifying the kernel core.
>
> @@ -104,19 +102,14 @@ static int need_to_sync_dir(struct f2fs_sb_info
> *sbi, struct inode *inode)
> struct dentry *dentry;
> nid_t pino;
>
> - inode = igrab(inode);
> - dentry = d_find_any_alias(inode);
> - if (!dentry) {
> - iput(inode);
> + dentry = list_entry(inode->i_dentry.next, struct dentry,
> d_alias);
> + if (!dentry)
> return 0;
> - }
> pino = dentry->d_parent->d_inode->i_ino;
> - dput(dentry);
> - iput(inode);
> return !is_checkpointed_node(sbi, pino);
> }
>
I initially thought exporting a symbol was not a big deal, but it is
certainly not the right thing to do. I very much prefer your patch.
Fixed now, thanks for your input!
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
