Re: [PATCH] fs: check f_op before dereference its field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2013 at 10:53:20PM +0800, Jiang Fang wrote:
> I don't know whether we can have NULL f_op today, but a quick
> grep of '!file->f_op->' in fs directory shows most of times we
> do the check. So fix the missing one.

We should remove the bogus ones, actually, and hunt down the remaining
few places that set ->f_op to NULL (AFAICS, all of them in dvb and
in ->release() instances, at that; note that no methods can be ever
called after ->release(), so these assignments are pointless _and_
irrelevant for any call sites of the methods).
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux