On Fri, 2013-01-18 at 21:54 -0800, Eric Dumazet wrote:
>
> Hmm, this might be already fixed in net-next tree, could you try it ?
>
Yes, running your program on net-next seems OK.
David, we need the two following commits.
They actually fixed a bug : current code in Linus tree
can push to the pipe a 0-length frag, because of the :
flen = min_t(unsigned int, flen, PAGE_SIZE - poff);
It can happen if poff == PAGE_SIZE, when one skb frag has this
particular starting offset.
commit 9ca1b22d6d228177e6f929f6818a1cd3d5e30c4a
Author: Eric Dumazet <edumazet@xxxxxxxxxx>
Date: Sat Jan 5 21:31:18 2013 +0000
net: splice: avoid high order page splitting
splice() can handle pages of any order, but network code tries hard to
split them in PAGE_SIZE units. Not quite successfully anyway, as
__splice_segment() assumed poff < PAGE_SIZE. This is true for
the skb->data part, not necessarily for the fragments.
This patch removes this logic to give the pages as they are in the skb.
Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Willy Tarreau <w@xxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
commit 18aafc622abf492809723d9c5a3c5dcea287169e
Author: Eric Dumazet <edumazet@xxxxxxxxxx>
Date: Fri Jan 11 14:46:37 2013 +0000
net: splice: fix __splice_segment()
commit 9ca1b22d6d2 (net: splice: avoid high order page splitting)
forgot that skb->head could need a copy into several page frags.
This could be the case for loopback traffic mostly.
Also remove now useless skb argument from linear_to_page()
and __splice_segment() prototypes.
Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Willy Tarreau <w@xxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
