2013/1/15, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>:
> 2013-01-15 (화), 20:50 +0900, Namjae Jeon:
>> 2013/1/15, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>:
>> > [snip]
>> >
>> >> void f2fs_destroy_stats(struct f2fs_sb_info *sbi)
>> >> {
>> >> struct f2fs_stat_info *si = sbi->stat_info;
>> >> @@ -354,7 +339,15 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi)
>> >> kfree(sbi->stat_info);
>> >> }
>> >>
>> >> -void destroy_root_stats(void)
>> >> +void __init f2fs_create_root_stats(void)
>> >
>> > We don't need to add __init here, right?
>> As you know, the function f2fs_create_root_stats will only be needed
>> at the init time of F2FS filesystem. So, there is no harm making this
>> function part of __init section, as this function will never be called
>> again.
>
> Oh, I meant it for code consistency at this moment.
> No other functions declare that though.
> Do we need to write another patch to add __init globally?
Yes, needed. I will send you another patch for __init today.
Thank you !
>
>> Thanks.
>> > Anyway, this patch looks much better to me.
>> >
>> > Jianpeng, how do you think about this?
>> >
>> > --
>> > Jaegeuk Kim
>> > Samsung
>> >
>
> --
> Jaegeuk Kim
> Samsung
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
