On Mon 07-01-13 20:39:41, Fernando Luis Vázquez Cao wrote: > Now that sb-level/bdev-level fsfreeze integration has been achieved and > sb-lebel/bdev-level freeze counters are always kept consistent, we need to > unfreeze bdevs in addition to filesystems during emergency thaw so that > we can recover from a situation where someone forgot to call thaw_bdev(). Looks good. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> A typo fix below: <snip> > +void do_thaw_one_bdev(struct block_device *bdev, void *arg) > +{ > + struct super_block *sb; > + > + mutex_lock(&bdev->bd_fsfreeze_mutex); > + > + if (!bdev->bd_fsfreeze_count) { > + mutex_unlock(&bdev->bd_fsfreeze_mutex); > + return; > + } > + > + /* > + * We know the block device is frozen so we do not need to grab a > + * reference - the first call to thaw_bdev() dit it. ^^^ did -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html