On Sat, Dec 29, 2012 at 03:36:38PM +0800, Hillf Danton wrote: > On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet <koverstreet@xxxxxxxxxx> wrote: > > - /* > > - * This is so that aio_complete knows it doesn't need to > > - * pull the iocb off the run list (We can't just call > > - * INIT_LIST_HEAD because we don't want a kick_iocb to > > - * queue this on the run list yet) > > - */ > > - iocb->ki_run_list.next = iocb->ki_run_list.prev = NULL; > > The tricky, list.next = NULL, is erased here, but it is reused in one of > the subsequent patches, why? I think you're confusing the two different linked lists - there's ki_run_list, which isn't used anymore after this patch (and deleted here), and ki_list, which is used for cancellation. Yeah, it's tricky and ugly. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
