On 12/28, Oleg Nesterov wrote: > > On 12/28, Andrey Vagin wrote: > > > > @@ -338,6 +379,7 @@ SYSCALL_DEFINE4(signalfd4, int, ufd, sigset_t __user *, user_mask, > > } > > > > file->f_flags |= flags & SFD_RAW; > > + file->f_mode |= FMODE_PREAD; > > Again, this is not needed or the code was broken by the previous patch. > > Given that 2/3 passes O_RDWR to anon_inode_getfile() I think FMODE_PREAD > should be already set. Note OPEN_FMODE(flags) in anon_inode_getfile(). As you explained in another thread I was wrong, I confused FMODE_PREAD and FMODE_READ. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
