On 11/28/2012 03:14 AM, Dave Chinner wrote: > +static long super_cache_count(struct shrinker *shrink, struct shrink_control *sc) > +{ > + struct super_block *sb; > + long total_objects = 0; > + > + sb = container_of(shrink, struct super_block, s_shrink); > + > + if (!grab_super_passive(sb)) > + return -1; > + You're missing the GFP_FS check here. This leads to us doing all the counting only to find out later, in the scanner, that we won't be able to free it. Better exit early. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html