Re: [PATCH 1/2] [PATCH 1/2] direct-io: implement generic deferred AIO completions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 06, 2012 at 08:05:37PM +0100, Jan Kara wrote:
>   I like this, but this patch already breaks ext4, doesn't it?

>   ^^^ Here ext4 offloads IO completion to a worker thread. So you now
> complete AIO / DIO before ext4_end_io() runs which is a bug (ext4_end_io()
> is responsible for example for calling end_page_writeback()). I'll modify
> these patches to work for ext4 tomorrow I hope...

You're right, patch 2 actively deadlocks ext4 under xfstests, but the
first one already breaks semantics.  So any rework of the ext4 unwritten
extent handling really should go before these two patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux