On Mon, Dec 03, 2012 at 09:21:34PM -0600, Dave Kleikamp wrote: > I'm not sure what's preferable here. As the comment states, the code is > making an effort to avoid a cache miss by avoiding the reference to bdev > when possible. If this micro-optimization is worth keeping, then it's a > question of which is uglier, this new function that modifies blkbits, or > duplicating this bit of code three times. The optimization was a quite measurable win on a large OLTP benchmark. I think it's worth keeping. -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
